DataViews: Use i18n._x to clarify term "Duplicate" #57686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These labels all refer to actions, where "duplicate" is meant as a verb. For a translator, that context was not clear, as "duplicate" could have been understood to be an adjective.
mcsf
added
Internationalization (i18n)
|
Size Change: +29 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
oandregal
added
[Type] Experimental
|
I made this change to labels: 
The reason is that these are used to clasify PRs in the changelog. By being consistent and tagging everything Dataviews with "experimental" we'll have them grouped together, making the release manager life easier. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Swap
__for_xwhen generating certain UI strings in order to provide the contextaction labelto translators.Why?
"Duplicate", "Duplicate pattern", "Duplicate template part": these labels all refer to actions, where "duplicate" is meant as a verb. For a translator, that context was not clear, as "duplicate" could have been understood to be an adjective.
Testing Instructions
No changes should occur.
Testing Instructions for Keyboard
Screenshots or screencast